[
https://issues.apache.org/jira/browse/LUCENE-3687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186328#comment-13186328
]
Simon Willnauer commented on LUCENE-3687:
-----------------------------------------
bq. in PreFlexRW and SimpleText's impl:
I agree this should be UOE
bq. shouldn't we combine Norm and DocValueNorm into one final class (Norm) and
pull it out of Sim?
I kind of like the separation here. DocValues is really the Codec side of
things and it would be nice if we would not mix that stuff in the similarity
API.
bq. If this is the case, aren't we now able to represent (in 4.x codec) that
norms are not omitted for the field, they just don't exist at all (e.g. all
documents without norms are deleted).
yeah we can do that I will look into it but I am not sure if we should rather
let that patch bake in for a bit and then do that change in a second issue.
Would make debugging simpler if we run into problems.
bq. from 'omitNorms for this field always', that we would just have
normValueType as null, and it would all just work?
I agree, maybe its better to get this right in this patch already I can still
move the stupid file checks removed in a second issue. But I should really
handle null types ie. Sims that don't set a value, currently I have tons of
asserts that enforce a value.
> Allow similarity to encode norms other than a single byte
> ---------------------------------------------------------
>
> Key: LUCENE-3687
> URL: https://issues.apache.org/jira/browse/LUCENE-3687
> Project: Lucene - Java
> Issue Type: New Feature
> Components: core/index, core/search
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0
>
> Attachments: LUCENE-3687.patch, LUCENE-3687.patch, LUCENE-3687.patch
>
>
> LUCENE-3628 cut over norms to docvalues. This removes the long standing
> limitation that norms are a single byte. Yet, we still need to expose this
> functionality to Similarity to write / encode norms in a different format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
