[
https://issues.apache.org/jira/browse/LUCENE-3690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Rowe updated LUCENE-3690:
--------------------------------
Attachment: LUCENE-3690.patch
Here is the final patch.
{quote}
bq. sarowe: oh, you mean: don't even attempt back-compat - just provide the
ability to use the previous implementation
right, this is what we did with DateField a while back, note the CHANGES.txt
entry on r658003. now that we have luceneMatchVersion though i kind of go back
and forth on when to use it to pick an impl vs when to do stuff like this.
dealers choice...
https://svn.apache.org/viewvc?view=revision&revision=658003
{quote}
I took the same approach - here are the changes from the previous version of
the patch:
# The previous {{HTMLStripCharFilter}} implementation is moved to Solr, renamed
to {{LegacyHTMLStripCharFilter}}, and deprecated, and a Factory is added for it.
# {{JFlexHTMLStripCharFilter}} is renamed to {{HTMLStripCharFilter}}.
# Support for {{HTMLStripCharFilter}}'s "escapedTags" functionality is added to
{{HTMLStripCharFilterFactory}}.
# Added {{TestHTMLStripCharFilterFactory}}.
# Solr and Lucene {{CHANGES.txt}} entries are added.
Run the following svn copy script before applying the patch:
{noformat}
svn cp
modules/analysis/common/src/java/org/apache/lucene/analysis/charfilter/HTMLStripCharFilter.java
solr/core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilter.java
svn cp
modules/analysis/common/src/test/org/apache/lucene/analysis/charfilter/htmlStripReaderTest.html
solr/core/src/test/org/apache/solr/analysis/
svn cp
modules/analysis/common/src/test/org/apache/lucene/analysis/charfilter/HTMLStripCharFilterTest.java
solr/core/src/test/org/apache/solr/analysis/LegacyHTMLStripCharFilterTest.java
svn cp
solr/core/src/java/org/apache/solr/analysis/HTMLStripCharFilterFactory.java
solr/core/src/java/org/apache/solr/analysis/LegacyHTMLStripCharFilterFactory.java
{noformat}
I plan to commit to trunk shortly, then backport and commit to branch_3x.
> JFlex-based HTMLStripCharFilter replacement
> -------------------------------------------
>
> Key: LUCENE-3690
> URL: https://issues.apache.org/jira/browse/LUCENE-3690
> Project: Lucene - Java
> Issue Type: New Feature
> Components: modules/analysis
> Affects Versions: 3.5, 4.0
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Fix For: 3.6, 4.0
>
> Attachments: BaselineWarcTest.java, HTMLStripCharFilterWarcTest.java,
> JFlexHTMLStripCharFilterWarcTest.java, LUCENE-3690.patch, LUCENE-3690.patch,
> LUCENE-3690.patch, LUCENE-3690.patch, LUCENE-3690.patch
>
>
> A JFlex-based HTMLStripCharFilter replacement would be more performant and
> easier to understand and maintain.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
