[ https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202463#comment-13202463 ]
Uwe Schindler commented on LUCENE-3736: --------------------------------------- Please keep the chained APIs, otherwise please also change all toString() methods in whole Lucene to no longer chain and rename all classes to no longer be called Builder with build() as method. If you keep the class names and disallow chaing you break the pattern and that will confuse people more. For me the issue is closed as I disagree, somebody else can do this :( > ParallelReader is now atomic, rename to ParallelAtomicReader and also add a > ParallelCompositeReader (that requires LogDocMergePolicy to have identical > subreader structure) > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-3736 > URL: https://issues.apache.org/jira/browse/LUCENE-3736 > Project: Lucene - Java > Issue Type: Sub-task > Components: core/index > Reporter: Uwe Schindler > Assignee: Michael McCandless > Fix For: 4.0 > > Attachments: LUCENE-3733.patch, LUCENE-3736.patch, LUCENE-3736.patch, > LUCENE-3736.patch > > > The plan is: > - Move all subreaders to ctor (builder-like API. First build reader-set, then > call build) > - Rename ParallelReader to ParallelAtomicReader > - Add a ParallelCompositeReader with same builder API, but taking any > CompositeReader-set and checks them that they are aligned (docStarts > identical). The subreaders are ParallelAtomicReaders. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org