[ https://issues.apache.org/jira/browse/LUCENE-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202489#comment-13202489 ]
Michael McCandless commented on LUCENE-3736: -------------------------------------------- I think the changes here are awesome too -- ParallelReader has been badly unloved for a long time, so I'm very happy we are improving it here. But I don't think we need to have chained APIs to achieve that good progress. Chained APIS are dangerous. We added chained APIs in IndexWriterConfig and I think that was a mistake... it gave us lots of not-so-readable code. We shouldn't encourage that and we shouldn't add more. > ParallelReader is now atomic, rename to ParallelAtomicReader and also add a > ParallelCompositeReader (that requires LogDocMergePolicy to have identical > subreader structure) > --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: LUCENE-3736 > URL: https://issues.apache.org/jira/browse/LUCENE-3736 > Project: Lucene - Java > Issue Type: Sub-task > Components: core/index > Reporter: Uwe Schindler > Fix For: 4.0 > > Attachments: LUCENE-3733.patch, LUCENE-3736.patch, LUCENE-3736.patch, > LUCENE-3736.patch > > > The plan is: > - Move all subreaders to ctor (builder-like API. First build reader-set, then > call build) > - Rename ParallelReader to ParallelAtomicReader > - Add a ParallelCompositeReader with same builder API, but taking any > CompositeReader-set and checks them that they are aligned (docStarts > identical). The subreaders are ParallelAtomicReaders. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org