[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206414#comment-13206414
]
Robert Muir commented on LUCENE-3774:
-------------------------------------
{quote}
The task can be used per-module (even if I don't see the point of this), not
necessarily at the top level (it's just a matter of the fileset/ mapper used).
{quote}
There are a few advantages: having compile/test/javadocs/licensecheck/...
per-module in the common-build means that the entire definition for a module is
pretty self-contained.
It means we can easily add/disable modules without editing many 'global' files.
In most cases a module won't have to specify anything, the default task looking
at all jar files in /lib? would be fine.
On the other hand, a top-level task that looks for all jar files is going to be
more complicated,
for example it will fail if it does not have logic to ignore start.jar/post.jar
in the solr example (no idea what other exceptions may exist).
> check-legal isn't doing its job
> -------------------------------
>
> Key: LUCENE-3774
> URL: https://issues.apache.org/jira/browse/LUCENE-3774
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/build
> Affects Versions: 3.6, 4.0
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Attachments: LUCENE-3774.patch, LUCENE-3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any
> {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories
> are not being checked; and {{check-legal-solr}} can't be checking
> {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
> in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in
> which to check, but modules move around, and these lists are not being kept
> up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a
> {{lib/}} directory, and it should be specialized for modules that have more
> than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard
> place ({{lucene/core/}}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
