[
https://issues.apache.org/jira/browse/LUCENE-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13206465#comment-13206465
]
Dawid Weiss commented on LUCENE-3774:
-------------------------------------
Hi Steven. I will merge the changes, no problem. As for committing this in,
let's wait until folks have some time to express if they prefer per-module or
global checks. I left per-module validation hooks in place as far as I
remember, so we could move it down from top-level if needed. It shouldn't even
affect performance _that_ much; I just think it's cleaner if done at top-level,
that's all.
As for Jenkins: if builds are done per-subproject (Lucene, Solr) then indeed
this validation wouldn't be executed. I imagine at least one plan should run
full top-level build though so something would fire a build exception in case
of validation errors?
As for git vs. svn patch -- I've looked at this:
http://stackoverflow.com/questions/3418277/how-to-apply-git-diff-patch
I'll re-generate the patch.
> check-legal isn't doing its job
> -------------------------------
>
> Key: LUCENE-3774
> URL: https://issues.apache.org/jira/browse/LUCENE-3774
> Project: Lucene - Java
> Issue Type: Improvement
> Components: general/build
> Affects Versions: 3.6, 4.0
> Reporter: Steven Rowe
> Assignee: Steven Rowe
> Attachments: LUCENE-3774.patch, LUCENE-3774.patch, LUCENE-3774.patch
>
>
> In trunk, the {{check-legal-lucene}} ant target is not checking any
> {{lucene/contrib/\*\*/lib/}} directories; the {{modules/**/lib/}} directories
> are not being checked; and {{check-legal-solr}} can't be checking
> {{solr/example/lib/\*\*/\*.jar}}, because there are currently {{.jar}} files
> in there that don't have a license.
> These targets are set up to take in a full list of {{lib/}} directories in
> which to check, but modules move around, and these lists are not being kept
> up-to-date.
> Instead, {{check-legal-\*}} should run for each module, if the module has a
> {{lib/}} directory, and it should be specialized for modules that have more
> than one ({{solr/core/}}) or that have a {{lib/}} directory in a non-standard
> place ({{lucene/core/}}).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
