[
https://issues.apache.org/jira/browse/LUCENE-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214606#comment-13214606
]
Robert Muir commented on LUCENE-3820:
-------------------------------------
OK, after reviewing in detail...
+1 I like the cleanup here!
I don't have an opinion / don't know the use case behind block delimiters, but
this is a
small, clean, elegant implementation that doesnt cause offsets problems (from
my futzing
around there seemed to be at least 2 bugs, one at the beginning and one at the
end?)
> Wrong trailing index calculation in PatternReplaceCharFilter
> ------------------------------------------------------------
>
> Key: LUCENE-3820
> URL: https://issues.apache.org/jira/browse/LUCENE-3820
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-3820.patch, LUCENE-3820.patch,
> LUCENE-3820_test.patch, LUCENE-3820_test.patch
>
>
> I need to use PatternReplaceCharFilter's index corrections directly and it
> fails for me -- the trailing index is not mapped correctly for a pattern
> "\\.[\\s]*" and replacement ".", input "A. .B.".
> I tried to understand the logic in getReplaceBlock but I eventually failed
> and simply rewrote it from scratch. After my changes a few tests don't pass
> but I don't know if it's the tests that are screwed up or my logic. In
> essence, the difference between the previous implementation and my
> implementation is how indexes are mapped for shorter replacements. I shift
> indexes of shorter regions to the "right" of the original index pool and the
> previous patch seems to squeeze them to the left (don't know why though).
> If anybody remembers how it's supposed to work, feel free to correct me?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
