[
https://issues.apache.org/jira/browse/LUCENE-3820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-3820:
--------------------------------
Description: Reimplementation of PatternReplaceCharFilter to pass
randomized tests (used to throw exceptions previously). Simplified code,
dropped boundary characters, full input buffered for pattern matching. (was: I
need to use PatternReplaceCharFilter's index corrections directly and it fails
for me -- the trailing index is not mapped correctly for a pattern "\\.[\\s]*"
and replacement ".", input "A. .B.".
I tried to understand the logic in getReplaceBlock but I eventually failed and
simply rewrote it from scratch. After my changes a few tests don't pass but I
don't know if it's the tests that are screwed up or my logic. In essence, the
difference between the previous implementation and my implementation is how
indexes are mapped for shorter replacements. I shift indexes of shorter regions
to the "right" of the original index pool and the previous patch seems to
squeeze them to the left (don't know why though).
If anybody remembers how it's supposed to work, feel free to correct me?)
Fix Version/s: 3.6
> Wrong trailing index calculation in PatternReplaceCharFilter
> ------------------------------------------------------------
>
> Key: LUCENE-3820
> URL: https://issues.apache.org/jira/browse/LUCENE-3820
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: 3.6, 4.0
>
> Attachments: LUCENE-3820.patch, LUCENE-3820.patch,
> LUCENE-3820_test.patch, LUCENE-3820_test.patch
>
>
> Reimplementation of PatternReplaceCharFilter to pass randomized tests (used
> to throw exceptions previously). Simplified code, dropped boundary
> characters, full input buffered for pattern matching.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
