[ 
https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225639#comment-13225639
 ] 

Hoss Man commented on SOLR-3218:
--------------------------------

bq. I believe start/end currency equality is enforced by MoneyType.compareTo 
which will throw an exception when end is compared to the first (start+gap).

Ah ..ok.  and then ultimately start+gap is compared to end (even if hardend is 
false) so you'll get a exception then.  ok fair enough.

bq. As far as enforcing currency equality being a good idea or not, it would 
make sense and I would prefer if start/end/gap currencies didn't need to be 
equal. This patch doesn't allow for that given the tradeoff of the utility of 
being able to use different currencies versus the annoyance of keeping a handle 
open to an ExchangeRateProvider in the places we'd need it.

I'm not completley understanding, but i don't need to: If it's easier/simpler 
(for now) to require that start/end/gap are all in the same currency that's 
fine -- we should just test/document that clearly .. we can alwasy relax that 
restriction later if you think of a clean/easy way to do it.

like i said before: it's probably silly to do it anyway, i just didn't 
understand if/what the complication was
                
> Range faceting support for CurrencyField
> ----------------------------------------
>
>                 Key: SOLR-3218
>                 URL: https://issues.apache.org/jira/browse/SOLR-3218
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Jan Høydahl
>             Fix For: 4.0
>
>         Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for 
> CurrencyField

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to