[ 
https://issues.apache.org/jira/browse/SOLR-3218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13228644#comment-13228644
 ] 

Hoss Man commented on SOLR-3218:
--------------------------------

bq. I updated CurrencyValue.toString() to return "3.14,USD" for $3.14 rather 
than "314,USD". My feeling is that it's more straight forward to return strings 
that look like the values that were passed in to parse(). 

that sounds right.

the most important thing is that in the response from range faceting, where it 
gives you a (str) lower bound about a count, that lower bound should be a legal 
value when building a query against that field (ie: you can use it in a range 
query)  ... i'm pretty sure (if i understand correctly) that for CurrencyField 
that means "3.14,USD"

bq. I worry that relaxing the restriction on the gap may just be confusing 
without adding any real value. We may want to consider forcing gap to be the 
same as start and end so that things are more conceptually straight forward.

I believe you -- i've got no objection to locking that down, i just want to 
make sure that if we doc "you can't do this" that: a) the code actually fails 
if you try; and b) we have a test proving that the code will fail if you try.

(and if we decide later that it makes sense, we can relax things and change the 
test & docs)

                
> Range faceting support for CurrencyField
> ----------------------------------------
>
>                 Key: SOLR-3218
>                 URL: https://issues.apache.org/jira/browse/SOLR-3218
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Jan Høydahl
>             Fix For: 4.0
>
>         Attachments: SOLR-3218-1.patch, SOLR-3218-2.patch, SOLR-3218.patch, 
> SOLR-3218.patch
>
>
> Spinoff from SOLR-2202. Need to add range faceting capabilities for 
> CurrencyField

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to