[
https://issues.apache.org/jira/browse/SOLR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237410#comment-13237410
]
Chris Male commented on SOLR-435:
---------------------------------
{quote}
we definitely shouldn't modify QueryComponent ... the entire point of the issue
is that QueryComponent can't attempt to validate the q param, because it
doesn't know if/when the defType QParser requires it to exist – the individual
QParsers all need to throw clear errors if they require it and it's not
specified, that's really the whole reason this issue was opened in the first
place
{quote}
If the purpose of the QueryComponent is to be QParser agnostic and consequently
unable to know if the 'q' parameter is even relevant, shouldn't it be up to the
QParser to retrieve what it believes the query string to be from the request
parameters? Currently QueryComponent assumes the 'q' parameter value is the
query string, sets that as being the case in the ResponseBuilder and passes it
down to the QParser.
> QParser must validate existance/absense of "q" parameter
> --------------------------------------------------------
>
> Key: SOLR-435
> URL: https://issues.apache.org/jira/browse/SOLR-435
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.3
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 3.6, 4.0
>
> Attachments: SOLR-435_q_defaults_to_all-docs.patch
>
>
> Each QParser should check if "q" exists or not. For some it will be required
> others not.
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
> at org.apache.solr.common.util.StrUtils.splitSmart(StrUtils.java:36)
> at
> org.apache.solr.search.OldLuceneQParser.parse(LuceneQParserPlugin.java:104)
> at org.apache.solr.search.QParser.getQuery(QParser.java:80)
> at
> org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:67)
> at
> org.apache.solr.handler.SearchHandler.handleRequestBody(SearchHandler.java:150)
> ...
> {code}
> see:
> http://www.nabble.com/query-parsing-error-to14124285.html#a14140108
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
