[ 
https://issues.apache.org/jira/browse/SOLR-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237427#comment-13237427
 ] 

Chris Male commented on SOLR-435:
---------------------------------

You're absolutely right.  

I can see the advantages of having QParser's accept a generic String that they 
need to parse, whether it be the main query string or a filter query.  But in 
that case I don't think QParser's should also be trying to find the query 
string themselves in certain cases (such as ExtendedDisMaxQParser trying q.alt 
as an alternative source of a query string).  QParsers are not required to 
respect what the QueryComponent gives them, so you can specify whatever you 
like in 'q' or 'fq' and QParser can totally ignore it.

It just feels a little messy and confusing because wherever the query string 
identification occurs is where the validation should occur too, right?

                
> QParser must validate existance/absense of "q" parameter
> --------------------------------------------------------
>
>                 Key: SOLR-435
>                 URL: https://issues.apache.org/jira/browse/SOLR-435
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>             Fix For: 3.6, 4.0
>
>         Attachments: SOLR-435_q_defaults_to_all-docs.patch
>
>
> Each QParser should check if "q" exists or not.  For some it will be required 
> others not.
> currently it throws a null pointer:
> {code}
> java.lang.NullPointerException
>       at org.apache.solr.common.util.StrUtils.splitSmart(StrUtils.java:36)
>       at 
> org.apache.solr.search.OldLuceneQParser.parse(LuceneQParserPlugin.java:104)
>       at org.apache.solr.search.QParser.getQuery(QParser.java:80)
>       at 
> org.apache.solr.handler.component.QueryComponent.prepare(QueryComponent.java:67)
>       at 
> org.apache.solr.handler.SearchHandler.handleRequestBody(SearchHandler.java:150)
>         ...
> {code}
> see:
> http://www.nabble.com/query-parsing-error-to14124285.html#a14140108

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to