[ 
https://issues.apache.org/jira/browse/LUCENE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246767#comment-13246767
 ] 

Steven Rowe commented on LUCENE-3948:
-------------------------------------

I applied the patch, ran {{ant filter-pom-templates}} under lucene, {{chdir}}'d 
to {{lucene/build/poms/}}, and successfully ran the following:

* {{mvn -N -P bootstrap install}}
* {{mvn -DskipTests install}}
* {{mvn test}}

I think two things should change:

# {{ant get-maven-poms}}, the user-level POM acquisition target, should place 
the POMs in a directory at the same level as {{lucene/}} and {{solr/}} - it 
could be named {{maven-build/}} or something like that.  (Mixing Lucene and 
Solr build stuff together under {{lucene/}} is bad.)
# The build output directory should be under {{maven-build/}}, rather than the 
same dirs as those used by the Ant build.

                
> Experiment with placing poms outside of src
> -------------------------------------------
>
>                 Key: LUCENE-3948
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3948
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Chris Male
>            Priority: Minor
>         Attachments: LUCENE-3948.patch, LUCENE-3948.patch
>
>
> Recent work in LUCENE-3944 has changed how our generated pom.xml files are 
> handled during release preparation, placing them in build/ instead.  However 
> get-maven-poms still places the poms inside src/ so you can use them to drive 
> a build.  What I think would be ideal is if we could unify the release 
> handling of the poms and the normal building handling, so that the poms can 
> sit outside of src and serve both purposes.  
> Some time ago I investigated how the ANT project handles its own Maven 
> integration and it has its poms sitting in their own directory.  They then 
> reference the actual src locations inside the poms.  This works for ANT but 
> with a warning since some of their tests don't work due to how the Maven 
> surefire plugin works, so they skip their tests.
> I have done some quick testing of my own and this process does seem to work 
> for our poms and tests.  I now want to take this to a full scale POC and see 
> if it works fully.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to