[ 
https://issues.apache.org/jira/browse/LUCENE-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Steven Rowe updated LUCENE-3948:
--------------------------------

    Attachment: LUCENE-3948.patch

Patch, updated to current trunk, and also:

# regularizes {{module-path}} definitions to always be 
{{$\{top-level}}{{\}/$\{module-path}}{{\}}}, where {{top-level}} is a 
separately specified property;
# uses {{top-level}} in definitions that would otherwise have multiple 
{{../..}} path segments;
# removes definitions for {{project.build.directory}}, 
{{project.build.outputDirectory}} and {{project.build.testOutputDirectory}}, 
because these values are now the same as their defaults;
# adds a new {{surefire-top-level}} property based on {{top-level}} -- since 
maven-surefire-plugin runs tests with CWD {{<module>/target/test/}}, the path 
to access Solr's {{testlogging.properties}} file needs two extra {{../}}'s; and
# adds a new target {{clean-maven-build}} to the top-level {{build.xml}}.

{quote}
TODO

* Connect generate-maven-artifacts to this new process.
{quote}

This isn't necessary, since generate-maven-artifacts now uses a separate target 
to filter the POMs for release artifact production: {{filter-pom-templates}}; 
this target and {{get-maven-poms}} are now independent of each other.

{quote}
* Add mechanism to clean maven-build
{quote}

Done.

{quote}
* Add maven-build as an svn:ignore dir.
* Remove svn:ignore for pom.xml in src directories.
{quote}

These will need to be done.

I think this is ready to commit.
                
> Experiment with placing poms outside of src
> -------------------------------------------
>
>                 Key: LUCENE-3948
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3948
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>            Reporter: Chris Male
>            Priority: Minor
>         Attachments: LUCENE-3948.patch, LUCENE-3948.patch, LUCENE-3948.patch, 
> LUCENE-3948.patch
>
>
> Recent work in LUCENE-3944 has changed how our generated pom.xml files are 
> handled during release preparation, placing them in build/ instead.  However 
> get-maven-poms still places the poms inside src/ so you can use them to drive 
> a build.  What I think would be ideal is if we could unify the release 
> handling of the poms and the normal building handling, so that the poms can 
> sit outside of src and serve both purposes.  
> Some time ago I investigated how the ANT project handles its own Maven 
> integration and it has its poms sitting in their own directory.  They then 
> reference the actual src locations inside the poms.  This works for ANT but 
> with a warning since some of their tests don't work due to how the Maven 
> surefire plugin works, so they skip their tests.
> I have done some quick testing of my own and this process does seem to work 
> for our poms and tests.  I now want to take this to a full scale POC and see 
> if it works fully.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to