[
https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257942#comment-13257942
]
Chris Male commented on LUCENE-3997:
------------------------------------
I do echo Yonik's concern here, I don't think we should prevent inter-module
dependencies. I think if we move something to lucene/core, it should be
because we think its a core API/concept, not just because its used by multiple
modules. Analyzer fits into that category, it belongs in core because it is a
core concept.
Do we feel the same about TopGroups and GroupDocs? I kind of think we do. But
we should move them for that reason, not just to remove the dependency.
> join module should not depend on grouping module
> ------------------------------------------------
>
> Key: LUCENE-3997
> URL: https://issues.apache.org/jira/browse/LUCENE-3997
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core?
> Both grouping and join modules use these trivial classes, but join depends on
> grouping just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name.
> Anyway I think the change is pretty clean: its similar to having basic stuff
> like Analyzer.java in core,
> so other things can work with Analyzer without depending on any specific
> implementing modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
