[
https://issues.apache.org/jira/browse/LUCENE-3997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259074#comment-13259074
]
Michael McCandless commented on LUCENE-3997:
--------------------------------------------
I don't think we should combine the two modules.
While they do share a couple classes (to represent a 'grouped' result), the two
functions (joining and grouping) are really orthogonal: you can join w/o doing
grouping, and you can group w/o doing joining.
I think we should move TopGroups/GroupDocs to core.
> join module should not depend on grouping module
> ------------------------------------------------
>
> Key: LUCENE-3997
> URL: https://issues.apache.org/jira/browse/LUCENE-3997
> Project: Lucene - Java
> Issue Type: Task
> Affects Versions: 4.0
> Reporter: Robert Muir
> Fix For: 4.0
>
> Attachments: LUCENE-3997.patch, LUCENE-3997.patch
>
>
> I think TopGroups/GroupDocs should simply be in core?
> Both grouping and join modules use these trivial classes, but join depends on
> grouping just for them.
> I think its better that we try to minimize these inter-module dependencies.
> Of course, another option is to combine grouping and join into one module, but
> last time i brought that up nobody could agree on a name.
> Anyway I think the change is pretty clean: its similar to having basic stuff
> like Analyzer.java in core,
> so other things can work with Analyzer without depending on any specific
> implementing modules.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
