[
https://issues.apache.org/jira/browse/LUCENE-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258178#comment-13258178
]
Robert Muir commented on LUCENE-4003:
-------------------------------------
Feel free to take this one Uwe!
{quote}
FieldCacheTermsFilter and also the TermsFilter in contrib can go away and we
should instead use the sorted terms automaton (I always forget the name, Dawid,
sorry) as a new AtomatonQuery subclass.
{quote}
That one should maybe be separated out... i could help some. Looking at the
description of the thing, i think
in some situations it could be a speedup (imagine some of the terms dont exist
at all, etc).
Also i wonder about the API, it could still have the current add() api, and do
the sorting->automaton at the
end (e.g. rewrite), but imo thats wasteful since the automaton is independent
of the reader, so instead maybe it
could take Term[] up front.
Finally, a new expert ctor (maybe just protected) should be exposed to
AutomatonQuery:
currently you have:
{code}
public AutomatonQuery(final Term term, Automaton automaton) {
super(term.field());
this.term = term;
this.automaton = automaton;
this.compiled = new CompiledAutomaton(automaton);
}
{code}
But I would add AutomatonQuery(Term, Automaton, CompiledAutomaton), so that a
subclass
could pass an already-compiled automaton. This TermsFilter-query would use the
alternative
CompiledAutomaton ctor, passing true for finite, and false for simplify, since
we know
its finite and probably large (so simplification in general would hurt).
> FieldCacheRewriteMethod.java is in tests
> ----------------------------------------
>
> Key: LUCENE-4003
> URL: https://issues.apache.org/jira/browse/LUCENE-4003
> Project: Lucene - Java
> Issue Type: Bug
> Reporter: selckin
>
> I believe FieldCacheRewriteMethod was accidentally moved to the wrong place
> in r1158697 and should be src/main and not in src/test.
> Or is it something that you don't want people to use?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
