[ 
https://issues.apache.org/jira/browse/LUCENE-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274811#comment-13274811
 ] 

Robert Muir commented on LUCENE-4047:
-------------------------------------

And if you start to close MDW when tests have already failed, I'm not sure this
will provide a lot of benefits because MDW itself is really nothing at all but
a wrapper.

Chances are when a test has failed, closing the MDW will just immediately throw
an exception and not really accomplish anything, because MDW close() throws 
exception
if there are still open files in the directory it wraps. So nothing will really 
get
closed.


                
> Cleanup of LuceneTestCase
> -------------------------
>
>                 Key: LUCENE-4047
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4047
>             Project: Lucene - Java
>          Issue Type: Sub-task
>          Components: general/build, general/test
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.0
>
>         Attachments: LUCENE-4047.patch
>
>
> functionally split large blocks of code that do logically different things, 
> organize and order them into rules. Use RandomizedRunner facilities for 
> ensuring scope resources (Directory, temporary folders) are properly disposed 
> of. Use RandomizedRunner facilities for reporting reproduce message.
> I have a working branch for this at github. Polishing off the rough edges.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to