[jira] [Commented] (LUCENE-4047) Cleanup of LuceneTestCase

Mon, 14 May 2012 15:22:58 -0700

Robert Muir commented on Sub-task LUCENE-4047

Summary of concerns:

  • if we close the mdw and ignore exceptions, its not any better than today as in general the MDW will still have files open against it and will simply throw an exception and not actually close anything.
  • if we don't fix MDW etc to actually close (even when ugly stuff happens), then failed tests will cause leaks (imagine RAM directories piling up in the JVM)

So my opinion is, since the rest of this patch is a nice cleanup, we should commit it without the MDW.close() change... for now. We should separately open a issue to fix MDW and anything like it to always actually close() its delegate in a finally block, ensuring it doesn't lose any real exceptions from any of its openfiles/checkindex/crash/unrefed fields checks.
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators.
For more information on JIRA, see: http://www.atlassian.com/software/jira
--------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

Reply via email to