[ 
https://issues.apache.org/jira/browse/LUCENE-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291742#comment-13291742
 ] 

Michael McCandless commented on LUCENE-4087:
--------------------------------------------

I think this is a good baby step for 4.0.

But I think it's important the javadocs make it clear that if you change up the 
DV type for a given field, the behavior is undefined and we are free to improve 
it in the future.

Ideally I think apps should get clear exceptions on attempting to index a doc 
with an incompatible change to anything that is our effective schema 
(omitNorms, indexOptions, DV types, etc.).  For example, if a given field 
already omitNorms and you try to add a doc with that field not omitting norms, 
you should get a clear exception (it can only be an app bug, because on merge 
the norms will silently go away).  But let's open a separate issue for that...
                
> Provide consistent IW behavior for illegal meta data changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-4087
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4087
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0, 4.1, 5.0
>
>         Attachments: LUCENE-4087.patch
>
>
> Currently IW fails late and inconsistent if field metadata like an already 
> defined DocValues type or "un"-omitting norms.
> we can approach this similar to how we handle consistent field number and:
>  
> * throw exception if indexOptions conflict (e.g. omitTF=true versus
> false) instead of silently dropping positions on merge
> * same with omitNorms
> * same with norms types and docvalues types
> * still keeping field numbers consistent
> this way we could eliminate all these traps and just give an
> exception instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to