[
https://issues.apache.org/jira/browse/LUCENE-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291937#comment-13291937
]
Michael McCandless commented on LUCENE-4087:
--------------------------------------------
Patch looks good. +1
I think this patch now means that, depending on when flushes kick in,
you can sometimes apparently succeed in changing DV type for a field
(though on merge something strange can happen, eg suddenly "upgrading"
to a BYTES_XXX type) and other times hit an exception? Like the error
checking is now "intermittent" as seen from the app? You might think
everything is OK, push to production, and later (in production) hit a
new exception...
I think that's actually OK for now (this is all
best effort)... but I think we should clean this up (can come after 4.0)
so that the checking is consistent.
Can we shorten the javadoc to simply state "Changing the DocValue type
for a given field is not supported."? Sure we make best effort to
"recover" today but I don't think we should detail particulars of the
specific best effort we're doing in 4.0?
> Provide consistent IW behavior for illegal meta data changes
> ------------------------------------------------------------
>
> Key: LUCENE-4087
> URL: https://issues.apache.org/jira/browse/LUCENE-4087
> Project: Lucene - Java
> Issue Type: Improvement
> Components: core/index
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.0, 4.1, 5.0
>
> Attachments: LUCENE-4087.patch, LUCENE-4087.patch
>
>
> Currently IW fails late and inconsistent if field metadata like an already
> defined DocValues type or "un"-omitting norms.
> we can approach this similar to how we handle consistent field number and:
>
> * throw exception if indexOptions conflict (e.g. omitTF=true versus
> false) instead of silently dropping positions on merge
> * same with omitNorms
> * same with norms types and docvalues types
> * still keeping field numbers consistent
> this way we could eliminate all these traps and just give an
> exception instead.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
