[
https://issues.apache.org/jira/browse/SOLR-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-3623:
---------------------------
Attachment: SOLR-3623.patch
bq. So with the factory in this contrib module, the jar files should really be
going in contrib/analysis-extras/lucene-libs as part of the packaging process
just like the other dependencies this contrib module has, otherwise we should
move the factory to core (see below)
ok, cool. part of my missunderstanding was thinking that \*morfo\*.jar was
being included in the war because it was a dependency of something else that
was already in solr core.
bq. In my opinion, it would be nice because we could have a text_zh configured
in the example that indexes chinese as words. Currently to do this, you have to
deal with this huge hassle that is this crazy analysis-extras contrib which is
a big barrier for indexing Chinese text.
I've generally been a big proponent of the "small war" philosophy, but i
certainly appreciate the value/importance of having a clean out of hte box
experience for all langauges -- i would definitely be interested to hear what
other people think
For now, assuming that analysis-extras is the "correct" place for these
factories to live...
The attached patch rectifies the inconsistency and cleans up the core classpath
/ lucene-libs file copying issue (ie: remove the morfo & uima jars from the
war) by ensuring that the classpath and copy sources use a common list of jar
files (ie: you have to go out of your way to make them different). A similar
common list is used in the anslysis-extras build.xml to prevent them from every
falling out of sync. I also included some minor fixes to the README files for
both analysis-extras and uima
I've done some basic junit/package testing, and things *look* like they are
working as designed, ... but the one thing that still seems weird to me is the
way the morfologik-\*.jar files are treated differnetly then the icu4j\*.jar...
solr/contrib/analysis-extras/ivy.xml lists icu4j, and in the final Solr
packaging that jar winds up in contrib/analysis-extras/lib (along with it's
LICENSE/NOTICE) -- but for the morfologik-\*.jar those are not listed in
ivy.xml; instead the "analyzers-morfologik.fileset" is inherited from
contrib-build.xml and those jars wind up in contrib/analysis-extras/lucene-libs
-- w/o their LICENSE/NOTICE.
shouldn't all those third-party jars be treated consistently?
> analysis-extras lucene libraries are redundenly packaged (in war and in
> lucene-libs)
> ------------------------------------------------------------------------------------
>
> Key: SOLR-3623
> URL: https://issues.apache.org/jira/browse/SOLR-3623
> Project: Solr
> Issue Type: Bug
> Components: Build
> Reporter: Lance Norskog
> Assignee: Hoss Man
> Priority: Minor
> Fix For: 4.0, 5.0
>
> Attachments: SOLR-3623.patch
>
>
> Various dependencies for contrib/analysis-extras are packaged
> contrib/analysis-extras/lucene-libs (along with instructions in
> contrib/analysis-extras/README.txt that users need to include them
> explicitly) even though these jars are already hardcoded into the solr war
> file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
