[
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421103#comment-13421103
]
Robert Muir commented on LUCENE-4044:
-------------------------------------
{quote}
Just to clarify: i believe you're saying that this would simplify things for
end users because it would mean one less jar people need to load in (ie: bundle
the FooTokenizerFactory in the same jar as the FooTokenizer so no need to a
special solr contrib containing just the factory) ... correct?
{quote}
Yes.
{quote}
And in theory it would simplify things for developers because if we can remove
things like contrib/solr/analysis-extras then things like SOLR-3664 are
problematic in fewer situations.
{quote}
Yes.
{quote}
But (unless i'm missing something) nothing in this approach would actually
eliminate the requirement that Solr users configure <lib ... /> directives to
load these external jars (and any third party dependencies) to get the
factories+impls+third-party-deps ... correct?
{quote}
There is no magic. they have to put things in their classpath.
But the other major improvement i suggested was syntax too. Of course we must
still support FQDN and also the solr.XXX:
{noformat}
<charFilter class="solr.HtmlStripCharFilterFactory"/>
<tokenizer class="solr.StandardTokenizerFactory"/>
<filter class="solr.LowerCaseFilterFactory"/>
<filter class="solr.PorterStemFilterFactory"/>
{noformat}
But I think we should fix the examples and support (as the "new" syntax):
{noformat}
<charFilter name="htmlstrip"/>
<tokenizer name="standard"/>
<filter name="lowercase"/>
<filter name="porterstem"/>
{noformat}
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and
> CharFilterFactory
> ----------------------------------------------------------------------------------------
>
> Key: LUCENE-4044
> URL: https://issues.apache.org/jira/browse/LUCENE-4044
> Project: Lucene - Core
> Issue Type: Sub-task
> Components: modules/analysis
> Reporter: Chris Male
> Fix For: 4.0
>
> Attachments: LUCENE-4044.patch
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into
> the directories with what they create. This is going to hamper Solr's
> existing strategy for supporting {{solr.*}} package names, where it replaces
> {{solr}} with various pre-defined package names. One way to tackle this is
> to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for
> example, and find it wherever it is, as long as it is defined as a service.
> This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of
> meaning configurations could be less verbose, would aid in fully decoupling
> the analysis module from Solr, and make the analysis factories easier to
> interact with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
