[ 
https://issues.apache.org/jira/browse/LUCENE-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421138#comment-13421138
 ] 

Chris Male commented on LUCENE-4044:
------------------------------------

bq. Chris: I'm gonna scratch out a branch here and see if we can flesh this out.

Thanks for coming back to this Robert!  I was just thinking about returning to 
this issue.

{quote}
At least I think we should give it a try as it would be pretty much a win for 
everyone
to simplify this syntax and make these analysis modules real plugins (I'm 
frustrated with
things like SOLR-3623 / the hassle people have to go thru to use some of the 
lucene analyzers)
{quote}

Absolutely.  I'm a huge fan of the simplified syntax.  Every consumer of 
Lucene, Solr or not, would benefit from being able to easily retrieve these 
Factories.

Looking over the patch I see what you meant and I really like it.  I wonder 
whether we should integrate newInstance into NamedSPILoader and add getName() 
to the Factorys?  The getName impl can then do the classname clipping like 
currently done in the patch.
                
> Add NamedSPILoader support to TokenizerFactory, TokenFilterFactory and 
> CharFilterFactory
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4044
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4044
>             Project: Lucene - Core
>          Issue Type: Sub-task
>          Components: modules/analysis
>            Reporter: Chris Male
>             Fix For: 4.0
>
>         Attachments: LUCENE-4044.patch
>
>
> In LUCENE-2510 I want to move all the analysis factories out of Solr and into 
> the directories with what they create.  This is going to hamper Solr's 
> existing strategy for supporting {{solr.*}} package names, where it replaces 
> {{solr}} with various pre-defined package names.  One way to tackle this is 
> to use NamedSPILoader so we simply look up {{StandardTokenizerFactory}} for 
> example, and find it wherever it is, as long as it is defined as a service.  
> This is similar to how we support Codecs currently.
> As noted by Robert in LUCENE-2510, this would also have the benefit of 
> meaning configurations could be less verbose, would aid in fully decoupling 
> the analysis module from Solr, and make the analysis factories easier to 
> interact with.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to