+1, another great cleanup! Mike McCandless
http://blog.mikemccandless.com On Sat, Aug 11, 2012 at 9:53 PM, Robert Muir <[email protected]> wrote: > Here's a patch: http://pastebin.com/PQGSgBtT > > On Sat, Aug 11, 2012 at 9:29 AM, Michael McCandless > <[email protected]> wrote: >> +1 >> >> Mike McCandless >> >> http://blog.mikemccandless.com >> >> >> On Sat, Aug 11, 2012 at 9:27 AM, Robert Muir <[email protected]> wrote: >>> FieldsEnum seems kinda awkward, can we just have something like >>> Iterable<String> on Fields? >>> >>> so the consuming code i think would be easier. >>> >>> for (String field : fields) { >>> Terms terms = fields.terms(field); >>> ... >>> } >>> >>> I don't like that there are two ways to get the terms for a field >>> today, so there is duplicate logic or crazy >>> stuff to handle this Fields.terms(String) versus FieldsEnum.terms() >>> >>> -- >>> lucidimagination.com >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > > -- > lucidworks.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
