On Wed, Sep 5, 2012 at 9:03 AM, Erick Erickson <[email protected]> wrote:
> OK, through the miracles of modern IDEs  I can make all the
> changes (for tabs only) in just a few minutes, running tests now...
>
> NOTE: this is just the java files, and a really stupid substitution
> of two spaces for each and every tab. No, I didn't just reformat
> the whole source tree, though it was tempting I'll admit<G>...
>
> BUT. The freaking patch is 900K for 4x, and it touches 190 java
> files. I'll be happy to check all this in, but there's a lot of code out
> in branches, Git, what have you, and I want to give it a couple of
> days for people to object before possibly introducing a reconciliation
> nightmare.
>
> If nobody objects by the weekend, I'll just commit (I'll create a JIRA)
> both for 4x and trunk.

get rid of the tabs please!

My only concern is that some of this is generated files: e.g. jflex
generated. we shouldnt do anything to this generated code directly.

-- 
lucidworks.com

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to