@Uwe: Right, wasn't thinking, a fairly common happening.....
Note that this is fairly ugly in that the simple-minded substitution
I did isn't totally right. You get diff lines like:
return new FloatDocValues(this) {
@Override
public float floatVal(int doc) {
- return func(doc, vals);
+ return func(doc, vals);
}
@Override
public String toString(int doc) {
- return name() + '(' + vals.toString(doc) + ')';
+ return name() + '(' + vals.toString(doc) + ')';
}
};
}
where the tab stops were other than 2 spaces. Unfortunately, I think the
alternative is to reformat all the files where this substitution was done
or go through by hand and do them all. And I'm really reluctant to volunteer
to fix over 8,000 of these by hand.
I'd _like_ to reformat all the files, but we all know the problems
there. I propose
that if nobody (or not enough people) object, I'll check them in with the
ugly indentation and the bad indents can be fixed when people are working
on the specific sections of code. At least it's progress.
Or if the consensus is to reformat the offending files I can do that. Tedious
but not that time-consuming.
Let me know...
On Wed, Sep 5, 2012 at 9:50 AM, Robert Muir <[email protected]> wrote:
> No it didnt. these classes do not exist in trunk.
>
> On Wed, Sep 5, 2012 at 8:37 AM, Erick Erickson <[email protected]>
> wrote:
>> Interestingly, this check missed the FrenchStemFilter.java (and I
>> don't know what others)
>> that found tabs by doing a quick search of the Lucene source tree.
>> Does the ant task
>> skip deprecated classes?
>>
>> I like the check, I'll see about doing something about the tabs anyway,
>> that's
>> gruntwork after all...
>>
>>
>> On Wed, Sep 5, 2012 at 6:39 AM, Uwe Schindler (JIRA) <[email protected]> wrote:
>>>
>>> [
>>> https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448621#comment-13448621
>>> ]
>>>
>>> Uwe Schindler commented on LUCENE-4362:
>>> ---------------------------------------
>>>
>>> Yeah, and with the ANT check, so it is enforced!
>>> If somebody wants to use a tab, e.g. in a string, he can always do \t
>>>
>>>> ban tab-indented source
>>>> -----------------------
>>>>
>>>> Key: LUCENE-4362
>>>> URL: https://issues.apache.org/jira/browse/LUCENE-4362
>>>> Project: Lucene - Core
>>>> Issue Type: Task
>>>> Reporter: Robert Muir
>>>> Attachments: LUCENE-4362_core.patch
>>>>
>>>>
>>>> This makes code really difficult to read and work with.
>>>> Its easy enough to prevent.
>>>> {noformat}
>>>> Index: build.xml
>>>> ===================================================================
>>>> --- build.xml (revision 1380979)
>>>> +++ build.xml (working copy)
>>>> @@ -77,11 +77,12 @@
>>>> <or>
>>>> <containsregexp expression="@author\b" casesensitive="yes"/>
>>>> <containsregexp expression="\bno(n|)commit\b"
>>>> casesensitive="no"/>
>>>> + <containsregexp expression="\t" casesensitive="no"/>
>>>> </or>
>>>> </fileset>
>>>> <map from="${validate.currDir}${file.separator}" to="* "/>
>>>> </pathconvert>
>>>> - <fail if="validate.patternsFound">The following files contain @author
>>>> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> + <fail if="validate.patternsFound">The following files contain @author
>>>> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
>>>> </target>
>>>> {noformat}
>>>
>>> --
>>> This message is automatically generated by JIRA.
>>> If you think it was sent incorrectly, please contact your JIRA
>>> administrators
>>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [email protected]
>>> For additional commands, e-mail: [email protected]
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [email protected]
>> For additional commands, e-mail: [email protected]
>>
>
>
>
> --
> lucidworks.com
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
