[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449687#comment-13449687
]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
I took Robert's patch, applied it and spent some time on a flight playing with
tabs. I went through the diffs on a fast scan and indented some egregious
indentation that jumped out.
Honest, I tried to restrain myself when reformatting _code_ rather than just
indenting some stray lines, but in a few cases I just couldn't stand it and
reformatted a couple of files (almost all the lines had tabs anyway) and a few
complete methods that also had almost all tabbed lines so there shouldn't be
very many gratuitous changes...
However, a curious thing happens when I try "ant test". There's some kind of
never-ending process that I'm seeing occasionally on my machine. I won't have a
chance to really look at it for a bit, I'll report more detail when I do. I'll
need to roll back my changes and see if it occurs without them, the usual....
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4362_core.patch, LUCENE-4362.patch,
> LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author
> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
