[
https://issues.apache.org/jira/browse/LUCENE-4362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453393#comment-13453393
]
Erick Erickson commented on LUCENE-4362:
----------------------------------------
There's also a section of comments that's tabbed in the generated file, it may
very well be the same issue of introducing tabs in the comments...
...../trunk/lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/standard/parser/StandardSyntaxParser.java
{noformat}
// QueryNode Query(CharSequence field) :
// {
// List clauses = new ArrayList();
// List modifiers = new ArrayList();
// QueryNode q, firstQuery=null;
// ModifierQueryNode.Modifier mods;
// int conj;
// }
// {
// mods=Modifiers() q=Clause(field)
// {
// if (mods == ModifierQueryNode.Modifier.MOD_NONE) firstQuery=q;
//
// // do not create modifier nodes with MOD_NONE
// if (mods != ModifierQueryNode.Modifier.MOD_NONE) {
// q = new ModifierQueryNode(q, mods);
// }
// clauses.add(q);
// }
// (
// conj=Conjunction() mods=Modifiers() q=Clause(field)
// {
// // do not create modifier nodes with MOD_NONE
// if (mods != ModifierQueryNode.Modifier.MOD_NONE) {
// q = new ModifierQueryNode(q, mods);
// }
// clauses.add(q);
// //TODO: figure out what to do with AND and ORs
// }
// )*
// {
// if (clauses.size() == 1 && firstQuery != null)
// return firstQuery;
// else {
// return new BooleanQueryNode(clauses);
// }
// }
// }
{noformat}
> ban tab-indented source
> -----------------------
>
> Key: LUCENE-4362
> URL: https://issues.apache.org/jira/browse/LUCENE-4362
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Assignee: Erick Erickson
> Attachments: LUCENE-4326_trunk.patch, LUCENE-4362_4x.patch,
> LUCENE-4362_4x.patch, LUCENE-4362_core.patch, LUCENE-4362.patch,
> LUCENE-4362.patch
>
>
> This makes code really difficult to read and work with.
> Its easy enough to prevent.
> {noformat}
> Index: build.xml
> ===================================================================
> --- build.xml (revision 1380979)
> +++ build.xml (working copy)
> @@ -77,11 +77,12 @@
> <or>
> <containsregexp expression="@author\b" casesensitive="yes"/>
> <containsregexp expression="\bno(n|)commit\b" casesensitive="no"/>
> + <containsregexp expression="\t" casesensitive="no"/>
> </or>
> </fileset>
> <map from="${validate.currDir}${file.separator}" to="* "/>
> </pathconvert>
> - <fail if="validate.patternsFound">The following files contain @author
> tags or nocommits:${line.separator}${validate.patternsFound}</fail>
> + <fail if="validate.patternsFound">The following files contain @author
> tags, tabs or nocommits:${line.separator}${validate.patternsFound}</fail>
> </target>
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
