On Mon, Sep 17, 2012 at 1:30 PM, Yonik Seeley <[email protected]> wrote:
> On Sun, Sep 16, 2012 at 2:51 PM, Robert Muir <[email protected]> wrote: > > not so much energy spent fixing these few shitty solr tests, some of > > which (Like TestReplicationHandler) are totally useless and have been > > failing sporatically for like, years. > > Can you explain why it's useless (without the derogatory adjectives > please)? > I'm not wanting to get into issues of usefulness of tests or not, but I did just look at the build failure messages over the last few months and I've received a build failure message for this test almost every single day. I appreciate that this doesn't happen locally and makes it hard to fix, but it's hard to work with continuous integration that so commonly fails on one test. > > I didn't write the test to begin with, so I don't know off the top of > my head all of the functionality it covers. I'd be surprised if it > was all redundant and covered by other test suites of course. > > Notes: > - I remember it passing for *long* periods of time > - I just ran it in a loop 30 times on my linux box and it passed 100% > of the time, and in a timely manner > - It *has* found many bugs when it started failing (i.e. usefull, not > useless) > - Many of us (including you) *have* worked to improve the situation > over time when it does deteriorate - check the logs. > > It's not clear what you are suggesting (unless you are volunteering to > look into this issue with OS-X apparently, or volunteering to write a > new replication test from scratch or something). > > -Yonik > http://lucidworks.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > -- Chris Male | Open Source Search Developer | elasticsearch | www.e<http://www.dutchworks.nl> lasticsearch.com
