[ 
https://issues.apache.org/jira/browse/SOLR-3846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457212#comment-13457212
 ] 

Uwe Schindler commented on SOLR-3846:
-------------------------------------

I am fine with that patch, but I found more "localhosts" in tests, grep 
throughout lucene:

{noformat}
bash-4.1$ PATH=/bin find . -name '*.java' | xargs grep localhost
./solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestContentStreamDataSource.java:
     * on localhost at the specified port.
File 
./solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestSolrEntityProcessorEndToEnd.java:
  //rivate static final String SOLR_SOURCE_URL = "http://localhost:8983/solr";;
    return "http://localhost:"; + port + "/solr";
File ./solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java:
    return "localhost:" + zkProps.getClientPortAddress().getPort();
  // Given zkHost=localhost:1111,localhost:2222 this will inject
  // server.0=localhost:1112:1113
  // server.1=localhost:2223:2224
    String myHost = "localhost";
      // default to localhost:<solrPort+1001>
File 
./solr/core/src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java:
 *   
http://localhost:8983/solr/admin/file?file=schema.xml&contentType=text/plain
File 
./solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
    // maps "localhost:8983|localhost:7574" to a shuffled 
List("http://localhost:8983","http://localhost:7574";)
    // for back compat, a shards param with URLs like localhost:8983/solr will 
mean that this
File ./solr/core/src/java/org/apache/solr/handler/component/ShardResponse.java:
  /** What was the shard address that returned this response.  Example:  
"http://localhost:8983/solr"; */
File ./solr/core/src/java/org/apache/solr/schema/RandomSortField.java:
 * 
<li>http://localhost:8983/solr/select/?q=*:*&fl=name&sort=rand_1234%20desc</li>
 * 
<li>http://localhost:8983/solr/select/?q=*:*&fl=name&sort=rand_2345%20desc</li>
 * 
<li>http://localhost:8983/solr/select/?q=*:*&fl=name&sort=rand_ABDC%20desc</li>
 * <li>http://localhost:8983/solr/select/?q=*:*&fl=name&sort=rand_21%20desc</li>
File ./solr/core/src/java/org/apache/solr/util/SimplePostTool.java:
  private static final String DEFAULT_POST_URL = 
"http://localhost:8983/solr/update";;
     "  java -Durl=http://localhost:8983/solr/update/extract 
-Dparams=literal.id=a -Dtype=application/pdf -jar post.jar a.pdf\n"+
File ./solr/core/src/test/org/apache/solr/AnalysisAfterCoreReloadTest.java:
      String url = "http://localhost:"+port+context+"/"+name;
File ./solr/core/src/test/org/apache/solr/schema/TestBinaryField.java:
    String url = "http://localhost:"; + jetty.getLocalPort() + context;
File ./solr/core/src/test/org/apache/solr/search/TestSolrJ.java:
    String addr = "http://localhost:8983/solr";;
    HttpSolrServer client = new HttpSolrServer("http://localhost:8983/solr";);
File ./solr/core/src/test/org/apache/solr/TestSolrCoreProperties.java:
    String url = "http://localhost:"; + solrJetty.getLocalPort() + "/solr";
   * on localhost at the specified port.
File 
./solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrServer.java:
   *          <code>http://localhost:8983/solr/</code>" if you are using the
File 
./solr/solrj/src/java/org/apache/solr/client/solrj/impl/LBHttpSolrServer.java:
  // keys to the maps are currently of the form "http://localhost:8983/solr";
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java:
    String adminPath = "http://localhost:"+port+context+"/";;
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/embedded/MultiCoreExampleJettyTest.java:
      String url = "http://localhost:"+port+context+"/"+name;
    String baseURL = "localhost:"+port+context+"/";
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleJettyTest.java:
      String url = "http://localhost/?core=xxx";;
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/embedded/SolrExampleStreamingTest.java:
      String url = "http://localhost:"+port+context;       // smaller queue 
size hits locks more often
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleBinaryTest.java:
      String url = "http://localhost:"+port+context;
File ./solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleXMLTest.java:
      String url = "http://localhost:"; + port + context;
File 
./solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java:
      return "http://localhost:"; + port + "/solr";
File 
./solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:
  // protected String[] deadServers = 
{"does_not_exist_54321.com:33331/solr","localhost:33332/solr"};
      String url = "http://localhost:"; + port + context;
File 
./solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java:
      sb.append("localhost:").append(j.getLocalPort()).append(context);
File 
./solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java:
      sb.append("localhost:").append(j.getLocalPort()).append(context);
      sb.append("|localhost:").append(j2.getLocalPort()).append(context);
      String url = "http://localhost:"; + port + context + "/"
File ./solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java:
        String url = "http://localhost:"+port+context;
bash-4.1$
{noformat}

I think we should fix all of those in the same way, to be *consistent* in tests!
                
> TestReplicationHandler.test always (?) takes many minutes on OS X (lion)
> ------------------------------------------------------------------------
>
>                 Key: SOLR-3846
>                 URL: https://issues.apache.org/jira/browse/SOLR-3846
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 4.0-BETA, 5.0
>         Environment: OS X (Lion). Apparently (see Yonik's notes) this does 
> NOT happen on other op systems.
> java version "1.6.0_35"
> Java(TM) SE Runtime Environment (build 1.6.0_35-b10-428-11M3811)
> Java HotSpot(TM) 64-Bit Server VM (build 20.10-b01-428, mixed mode)
> Solr trunk and 4.x from 16-Sep, but it's been happening for a couple of weeks 
> at least.
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>             Fix For: 4.0, 5.0
>
>         Attachments: SOLR-3846.patch, SOLR-3846.patch, stacks.txt
>
>
> Here's the seed was using, but this is apparently unnecessary:
> <JUnit4> says ¡Hola! Master seed: 6785BB3284A15298
> _eventually_ it seems to complete, but it takes many minutes, for instance 
> this was reported once, but I usually lose patience and ctrl-c out:
> {code}
> [junit4:junit4] Completed on J2 in 2449.62s, 1 test
> [junit4:junit4] 
> [junit4:junit4] JVM J0:     1.21 ..   266.67 =   265.47s
> [junit4:junit4] JVM J1:     1.21 ..   238.33 =   237.12s
> [junit4:junit4] JVM J2:     1.21 ..  2538.60 =  2537.39s
> [junit4:junit4] JVM J3:     0.97 ..   267.37 =   266.40s
> [junit4:junit4] Execution time total: 42 minutes 18 seconds
> {code}
> and a lot of lines like:
> HEARTBEAT J2: 2012-09-16T17:38:38, no events in:  187s, approx. at: 
> TestReplicationHandler.test
> Yonik reports that he can make this happen 100% of the time on OS X/Lion, 
> which squares with my experience as I recall. Yonik also reports...
> On my linux box (built in '09, PhenomII, HDD) the test takes 50-55 sec.
> On my kids old windows box ('08, athlon64, HDD, Win7) the test takes 88-95 
> sec.
> On my mac it always takes forever, and I see loops of stuff like this:
> {code}
> SEVERE Master at: http://localhost:62803/solr is not available. Index
> fetch failed. Exception:
> org.apache.solr.client.solrj.SolrServerException: Server refused
> connection at: http://localhost:62803/solr
> [junit4:junit4]   2> 52751 T219 C17 UPDATE [collection1] webapp=/solr
> path=/update params={wt=javabin&version=2} {add=[150]} 0 0
> [junit4:junit4]   2> 52755 T219 C17 UPDATE [collection1] webapp=/solr
> path=/update params={wt=javabin&version=2} {add=[151]} 0 0
> [junit4:junit4]   2> 62758 T215 oash.SnapPuller.fetchLatestIndex
> SEVERE Master at: http://localhost:62803/solr is not available. Index
> fetch failed. Exception:
> {code}
> And I'm soooo happy it's not happening to others and just being swept under 
> the rug, restores my faith. I should have known better ;)
> See the discussion on the dev list labeled "being a good citizen is hard when 
> you can't successfully run tests" for more context.
> I don't know how much time I'll have to dive in to it but I'll certainly be 
> happy to test anyone's patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to