[
https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490614#comment-13490614
]
Simon Willnauer edited comment on LUCENE-4537 at 11/5/12 1:30 PM:
------------------------------------------------------------------
here is another option just for the record. I removed all public API of
RateLimiter from Directory & FSDirectory and made an overloaded createOutput
method that can be called from a wrapper dir. I mean this is not 100% detached
from dir but much cleaner than what we had before. I don't think we can simply
have a rate limited IndexOutput since it will not play nice with
BufferedIndexOutput. progress over perfection though...
was (Author: simonw):
here is another option just for the record.
> Move RateLimiter up to Directory and make it IOContext aware
> ------------------------------------------------------------
>
> Key: LUCENE-4537
> URL: https://issues.apache.org/jira/browse/LUCENE-4537
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4537.patch, LUCENE-4537.patch, LUCENE-4537.patch
>
>
> Currently the RateLimiter only applies to FSDirectory which is fine in
> general but always requires casts and other dir. impls (custom ones could
> benefit from this too.) We are also only able to rate limit merge operations
> which limits the functionality here a lot. Since we have the context
> information what the IndexOutput is used for we can use that for rate
> limiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
