[
https://issues.apache.org/jira/browse/LUCENE-4537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490634#comment-13490634
]
Robert Muir commented on LUCENE-4537:
-------------------------------------
I don't think ratelimiter should be in Directory at all: then its a bug if
XYZdir doesnt implement it.
Screw that: lets divorce this from directory completely as I suggested. Then it
works with all directories,
and they are totally unaware of it.
{quote}
I don't think we can simply have a rate limited IndexOutput since it will not
play nice with BufferedIndexOutput.
{quote}
I think this is some premature optimization.
APIs come first here!
> Move RateLimiter up to Directory and make it IOContext aware
> ------------------------------------------------------------
>
> Key: LUCENE-4537
> URL: https://issues.apache.org/jira/browse/LUCENE-4537
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/store
> Affects Versions: 4.0
> Reporter: Simon Willnauer
> Fix For: 4.1, 5.0
>
> Attachments: LUCENE-4537.patch, LUCENE-4537.patch, LUCENE-4537.patch
>
>
> Currently the RateLimiter only applies to FSDirectory which is fine in
> general but always requires casts and other dir. impls (custom ones could
> benefit from this too.) We are also only able to rate limit merge operations
> which limits the functionality here a lot. Since we have the context
> information what the IndexOutput is used for we can use that for rate
> limiting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
