[
https://issues.apache.org/jira/browse/LUCENE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509314#comment-13509314
]
Michael McCandless commented on LUCENE-4258:
--------------------------------------------
Trying to catch up here ... I just have a bunch of random questions
(don't fully understand the patch yet):
Not sure why some files show as all deleted / all added lines, eg at
least FrozenBufferedDeletes.java.
Patch also has tabs, which should be spaces... (eg IndexWriter.java).
Why do we have FieldsUpdate.Operation.ADD_DOCUMENT? It seems weird to
pass that to IW.updateFields? Shouldn't apps just use
IW.addDocument?
Why do we need SegmentInfoReader.readFilesList? It seems like it's
only privately used inside the codec? I'm confused why the "normal"
file tracking we have on write is insufficient... oh I see, a single
SegmentInfo references all stacked segments too? But since they are
written "later" their files won't be automatically tracked ... ok. I
wonder if each stacked segment should get its own SegmentInfo, linked
to the base segment...
It looks like merge policies don't yet know about / target stacked
segments ...
It seems like we don't invert the document updates until the updates
are applied? Ie, we just buffer the IndexableField provided by the
user and when it's time to apply updates, we then analyzing/invert?
How do we track RAM in this case? (Eg the field could be something
arbitrary, eg pre-tokenized). Another option is to do the invert and
buffer the resulting postings, and then later "replay" them (remapping
docIDs) when it's time to apply.
Why does StoredFieldsReader.visitDocument need a Set for ignored
fields?
> Incremental Field Updates through Stacked Segments
> --------------------------------------------------
>
> Key: LUCENE-4258
> URL: https://issues.apache.org/jira/browse/LUCENE-4258
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Sivan Yogev
> Attachments: IncrementalFieldUpdates.odp,
> LUCENE-4258-API-changes.patch, LUCENE-4258.r1410593.patch,
> LUCENE-4258.r1412262.patch, LUCENE-4258.r1416438.patch,
> LUCENE-4258.r1416617.patch
>
> Original Estimate: 2,520h
> Remaining Estimate: 2,520h
>
> Shai and I would like to start working on the proposal to Incremental Field
> Updates outlined here (http://markmail.org/message/zhrdxxpfk6qvdaex).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
