[
https://issues.apache.org/jira/browse/LUCENE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510441#comment-13510441
]
Sivan Yogev commented on LUCENE-4258:
-------------------------------------
Erick - thanks for the support!
Mike - thanks for the comments, here's an attempt to supply answers:
Regarding formatting and all deletes - I will check and try to fix those.
{quote}
Why do we have FieldsUpdate.Operation.ADD_DOCUMENT? It seems weird to
pass that to IW.updateFields? Shouldn't apps just use
IW.addDocument?
{quote}
We have ADD_ and REPLACE_ for FIELDS, and also REPLACE_DOCUMENTS, so having
ADD_DOCUMENT would allow applications to work only with updateFields. There
certainly are actions that can be performed in more than one way in this API,
do you find this too confusing?
{quote}
Why do we need SegmentInfoReader.readFilesList? ...
{quote}
I considered the alternative you propose of having a segmentInfo for each
stacked segment, and it seemed too complex to manage than what is done with
.del files, so I chose the .del files approach. You are right about it's
privacy, I removed it from SegmentInfoReader and the actual readers have it
privately.
{quote}
It looks like merge policies don't yet know about / target stacked
segments ...
{quote}
I was planning to have it in another issue. should I create it already?
{quote}
It seems like we don't invert the document updates until the updates
are applied? ...
{quote}
I went for the simple solution trying to introduce as less new concepts as
possible (and still the patch size is >7000 lines). Your proposal should
certainly be considered and maybe tested. I need to make sure I do the RAM
calculations right, the added documents must be reflected in the RAM
consumption of the deletions queue.
{quote}
Why does StoredFieldsReader.visitDocument need a Set for ignored
fields?
{quote}
When fetching stored fields from a segment with replacements, it is possible
that all contents of a certain field for the base and first n stacked segments
should be ignored. Therefore, the implementation starts the visiting from the
most recent updates. If we encounter at some stage a field replacement, that
field name is added to the Set of ignored fields, and later the content of that
field in the stacked segments we encounter (which are older updates) is ignored.
> Incremental Field Updates through Stacked Segments
> --------------------------------------------------
>
> Key: LUCENE-4258
> URL: https://issues.apache.org/jira/browse/LUCENE-4258
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Sivan Yogev
> Attachments: IncrementalFieldUpdates.odp,
> LUCENE-4258-API-changes.patch, LUCENE-4258.r1410593.patch,
> LUCENE-4258.r1412262.patch, LUCENE-4258.r1416438.patch,
> LUCENE-4258.r1416617.patch
>
> Original Estimate: 2,520h
> Remaining Estimate: 2,520h
>
> Shai and I would like to start working on the proposal to Incremental Field
> Updates outlined here (http://markmail.org/message/zhrdxxpfk6qvdaex).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
