I think if an issue is contentious, we should open a JIRA issue and come to consensus before making another change for that issue to the codebase.
Revert wars are not allowed. - Mark On Dec 13, 2012, at 5:56 PM, Robert Muir <[email protected]> wrote: > don't just revert my changes. I'm disabling this broken jvm to prevent > false fails. > > i can write a bot to do this. > > On Thu, Dec 13, 2012 at 5:53 PM, <[email protected]> wrote: >> Author: uschindler >> Date: Thu Dec 13 22:53:00 2012 >> New Revision: 1421598 >> >> URL: http://svn.apache.org/viewvc?rev=1421598&view=rev >> Log: >> no comment! >> >> Modified: >> >> lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java >> >> Modified: >> lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java >> URL: >> http://svn.apache.org/viewvc/lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java?rev=1421598&r1=1421597&r2=1421598&view=diff >> ============================================================================== >> --- >> lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java >> (original) >> +++ >> lucene/dev/trunk/lucene/test-framework/src/java/org/apache/lucene/util/TestRuleSetupAndRestoreClassEnv.java >> Thu Dec 13 22:53:00 2012 >> @@ -200,9 +200,6 @@ final class TestRuleSetupAndRestoreClass >> Arrays.toString(avoidCodecs.toArray())); >> throw e; >> } >> - if (Constants.JAVA_VENDOR.startsWith("IBM")) { >> - throw new AssumptionViolatedException("refusing to execute on broken >> jvm"); >> - } >> } >> >> /** >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
