[
https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomás Fernández Löbbe updated SOLR-4208:
----------------------------------------
Attachment: SOLR-4208.patch
A possible refactor:
* I separated the ExtendedDismaxQParser so it can be extended.
* I broke the "parse" method into smaller methods, easier to read.
* Separated the configuration (parsing and all the actual fields) to a
different class. DismaxQParser has too many configuration options, I think it's
going to be clear if we keep those separately.
* Using factory methods for the configuration and the ExtendedSolrQueryParser
so that an extending class could change the implementation of those classes.
* other minor changes.
Thoughts?
> Refactor edismax query parser
> -----------------------------
>
> Key: SOLR-4208
> URL: https://issues.apache.org/jira/browse/SOLR-4208
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: SOLR-4208.patch
>
>
> With successive changes, the edismax query parser has become more complex. It
> would be nice to refactor it to reduce code complexity, also to allow better
> extension and code reuse.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
