[
https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-4208:
---------------------------
Attachment: SOLR-4208.patch
reading through things, i think this is definitely an improvement over what we
have currently in terms of making things extensible in subclasses, and the test
look great. adding sub-plugins seems like overkill at this point, probably
best left for a future issue.
i've improved tomas's latest patch slightly, by moving the ASL to the top of
ExtendedDismaxQParser.java and setting up proper exception ignoring for those
expected "Field aliases lead to a cycle" errors that were getting logged (the
test already trie to make them ignored by using the "ignored_exception" magic
string in the query, but these errors don't include the "q" in the exception
message so it wasn't doing anything.
I'm running tests & precommit now ... but the one thing i'd really like to do
before committing is make sure all of these new/existing methods have decent
javadocs ... if we're making these changes to make subclassing easier, we
should make sure the jdocs are their for people who write subclasses so they
understand what each method does.
> Refactor edismax query parser
> -----------------------------
>
> Key: SOLR-4208
> URL: https://issues.apache.org/jira/browse/SOLR-4208
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Fix For: 4.2, 5.0
>
> Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch,
> SOLR-4208.patch, SOLR-4208.patch
>
>
> With successive changes, the edismax query parser has become more complex. It
> would be nice to refactor it to reduce code complexity, also to allow better
> extension and code reuse.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
