[ 
https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534888#comment-13534888
 ] 

Markus Jelsma commented on SOLR-4208:
-------------------------------------

I am on trunk too. I get some exceptions like:

{code}
[junit4:junit4]   2> 5475 T10 C0 oasc.SolrException.log SEVERE 
org.apache.solr.common.SolrException: org.apache.solr.search.SyntaxError: Field 
aliases lead to a cycle
...
{code}

and,

{code}
[junit4:junit4]   2> 6288 T10 oasc.SolrException.log SEVERE 
java.lang.NullPointerException
[junit4:junit4]   2>            at 
org.apache.solr.handler.component.HttpShardHandlerFactory.close(HttpShardHandlerFactory.java:170)
{code}

But they don't fail the unit test. The testAliasingBoost is marked as failed:

{code}
[junit4:junit4] Tests with failures:
[junit4:junit4]   - 
org.apache.solr.search.TestExtendedDismaxParser.testAliasingBoost
{code}

{code}
   <testcase classname="org.apache.solr.search.TestExtendedDismaxParser" 
name="testAliasingBoost" time="0.189">
      <error message="Exception during query" 
type="java.lang.RuntimeException">java.lang.RuntimeException: Exception during 
query
        at 
__randomizedtesting.SeedInfo.seed([9B33524C2584B3F3:57A2A7EB2388F581]:0)
        at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:515)
        at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:482)
        at 
org.apache.solr.search.TestExtendedDismaxParser.testAliasingBoost(TestExtendedDismaxParser.java:507)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1559)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner.access$600(RandomizedRunner.java:79)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:737)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:773)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:787)
        at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:53)
        at 
org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:50)
        at 
org.apache.lucene.util.TestRuleFieldCacheSanity$1.evaluate(TestRuleFieldCacheSanity.java:51)
        at 
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46)
        at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55)
        at 
org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:49)
        at 
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70)
        at 
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
        at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358)
        at 
com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:782)
        at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:442)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:746)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$3.evaluate(RandomizedRunner.java:648)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$4.evaluate(RandomizedRunner.java:682)
        at 
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:693)
        at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:53)
        at 
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:46)
        at 
org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:42)
        at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesInvariantRule$1.evaluate(SystemPropertiesInvariantRule.java:55)
        at 
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
        at 
com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:39)
        at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at 
org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:43)
        at 
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:48)
        at 
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:70)
        at 
org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:55)
        at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
        at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:358)
        at java.lang.Thread.run(Thread.java:662)
Caused by: java.lang.RuntimeException: REQUEST FAILED: 
xpath=//result/doc[1]/str[@name=&apos;id&apos;]=42
        xml response was: &lt;?xml version=&quot;1.0&quot; 
encoding=&quot;UTF-8&quot;?&gt;
&lt;response&gt;
&lt;lst name=&quot;responseHeader&quot;&gt;&lt;int 
name=&quot;status&quot;&gt;0&lt;/int&gt;&lt;int 
name=&quot;QTime&quot;&gt;1&lt;/int&gt;&lt;/lst&gt;&lt;result 
name=&quot;response&quot; numFound=&quot;2&quot; 
start=&quot;0&quot;&gt;&lt;doc&gt;&lt;str 
name=&quot;id&quot;&gt;47&lt;/str&gt;&lt;arr 
name=&quot;trait_ss&quot;&gt;&lt;str&gt;Pig&lt;/str&gt;&lt;/arr&gt;&lt;/doc&gt;&lt;doc&gt;&lt;str
 name=&quot;id&quot;&gt;42&lt;/str&gt;&lt;arr 
name=&quot;trait_ss&quot;&gt;&lt;str&gt;Tool&lt;/str&gt;&lt;str&gt;Obnoxious&lt;/str&gt;&lt;/arr&gt;&lt;str
 name=&quot;name&quot;&gt;Zapp Brannigan&lt;/str&gt;&lt;/doc&gt;&lt;/result&gt;
&lt;/response&gt;

        request 
was:f.myalias.qf=name+trait_ss^0.5&amp;q=Zapp+Pig&amp;qf=myalias&amp;defType=edismax
        at org.apache.solr.SolrTestCaseJ4.assertQ(SolrTestCaseJ4.java:508)
        ... 42 more
</error>
   </testcase>
{code}

I'm not sure what's going. This is a clean trunk check out.
                
> Refactor edismax query parser
> -----------------------------
>
>                 Key: SOLR-4208
>                 URL: https://issues.apache.org/jira/browse/SOLR-4208
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
>             Fix For: 4.1, 5.0
>
>         Attachments: SOLR-4208.patch
>
>
> With successive changes, the edismax query parser has become more complex. It 
> would be nice to refactor it to reduce code complexity, also to allow better 
> extension and code reuse.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to