[
https://issues.apache.org/jira/browse/SOLR-4208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540071#comment-13540071
]
Erik Hatcher commented on SOLR-4208:
------------------------------------
Tomas - regarding the idea of using Solr plugin points into the edismax parser
- on second thought it might be premature to put a plugin system in there at
this point. Given the couple of examples you've added to the test cases, doing
it with a subclass or an extension still requires Java coding and plugging in
something, so again it's probably overkill to consider the plugin thing. But
here's how it'd work (using the HighlighterComponent, such as formatter and
encoders) where a plugin was responsible for the multi-lingual field logic of
overriding the configuration object in your example, or a different plugin that
was used to plug in a response to getFieldQuery for your other example. But I
think leaving it how you've got it set up for subclassing works fine for now.
+1
> Refactor edismax query parser
> -----------------------------
>
> Key: SOLR-4208
> URL: https://issues.apache.org/jira/browse/SOLR-4208
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomás Fernández Löbbe
> Priority: Minor
> Fix For: 4.1, 5.0
>
> Attachments: qParserDiff.txt, SOLR-4208.patch, SOLR-4208.patch
>
>
> With successive changes, the edismax query parser has become more complex. It
> would be nice to refactor it to reduce code complexity, also to allow better
> extension and code reuse.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]