[ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548725#comment-13548725
 ] 

Robert Muir commented on LUCENE-4670:
-------------------------------------

{quote}
For example, if you want to flush data after every field has been added, today 
you need to do it both in the finish and startField methods, and in both cases 
you need to check whether startField had already been called earlier on. By 
having a finishField method, the modification is in one place and doesn't need 
an extra condition.
{quote}

Yeah I think this currently makes Lucene40's impl confusing too: check out its 
startField. If we can simplify that one too, i'm completely sold.

I still feel like we should do this to the stored fields api too though for 
consistency.
                
> Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
> formats easier
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4670
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4670
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4670.patch
>
>
> This is especially useful to LUCENE-4599 where actions have to be taken after 
> a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to