[ 
https://issues.apache.org/jira/browse/LUCENE-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13548765#comment-13548765
 ] 

Adrien Grand commented on LUCENE-4670:
--------------------------------------

bq. i think this looks better?

Yes it does!

bq. I can go either way on whether or not the finish() methods should be 
abstract though (versus having a no-op impl).

A no-op impl would make the change backward compatible?
                
> Add TermVectorsWriter.finish{Doc,Field,Term} to make development of new 
> formats easier
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-4670
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4670
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>             Fix For: 4.1
>
>         Attachments: LUCENE-4670.patch, LUCENE-4670.patch
>
>
> This is especially useful to LUCENE-4599 where actions have to be taken after 
> a doc/field/term has been added.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to