[
https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564021#comment-13564021
]
Mark Miller commented on SOLR-4196:
-----------------------------------
I'm going to take a closer look at the latest patch.
Have you added tests for the new core loading style? I think we want to heavily
exercise that in tests before committing.
Started to glance over the patch and saw some stylistic stuff - eg class
members starting with underscore - we should make that consistent with the
majority of the code base.
I'm also seeing some javadoc warnings to fix.
>From a high level, it all looks pretty good to me. I'll try and take some time
>to dig in over the next couple days though.
> Untangle XML-specific nature of Config and Container classes
> ------------------------------------------------------------
>
> Key: SOLR-4196
> URL: https://issues.apache.org/jira/browse/SOLR-4196
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Minor
> Fix For: 4.2, 5.0
>
> Attachments: SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch,
> SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch, SOLR-4196.patch,
> SOLR-4196.patch
>
>
> sub-task for SOLR-4083. If we're going to try to obsolete solr.xml, we need
> to pull all of the specific XML processing out of Config and Container.
> Currently, we refer to xpaths all over the place. This JIRA is about
> providing a thunking layer to isolate the XML-esque nature of solr.xml and
> allow a simple properties file to be used instead which will lead,
> eventually, to solr.xml going away.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
