According to https://wiki.apache.org/solr/HowToContribute, Sun's code style conventions should be used when writing contributions for Lucene and Solr. Said conventions state that lines in code should be 80 characters or less, "since they're not handled well by many terminals and tools": http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#313
A quick random inspection of the Lucene/Solr code base tells me that this recommendation is not followed: Out of 20 source files, only a single one adhered to the 80 characters/line limit and that was StorageField, which is an interface. I am all for a larger limit as I find that it makes Java code a lot more readable. With current tools, Java code needs to be formatted using line breaks and indents (as opposed to fully dynamic tool-specific re-flow of the code). That formatting is dependent on a specific maximum line width to be consistent. With that in mind, I suggest that the code style recommendation is expanded with the notion that a maximum of x characters/line should be used, where x is something more than 80. Judging by a quick search, 120 chars seems to be a common choice. Regards, Toke Eskildsen --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
