I'd actually never bothered to look at the line limitation, that's from back when I started programming. Mostly I was just soooo happy that someone had short-circuited the endless "whether braces should be on the same line or not" discussion. <G>....
P.S. the ''very'' is really an italic. P.P.S. Why programmers are different than the rest. Not _only_ have I been in the very "where should the braces go" discussions at various points in my life, but there's a Wiki article that's far too long.... http://en.wikipedia.org/wiki/One_True_Brace_Style#K.26R_style On Mon, Feb 25, 2013 at 9:55 AM, Erick Erickson <[email protected]>wrote: > Changed to: > lines can be greater than 80 chars long, 132 is a common limit. Try to be > reasonable for ''very'' long lines. > > > On Mon, Feb 25, 2013 at 9:51 AM, Uwe Schindler <[email protected]> wrote: > >> Hi, >> >> One interesting detail: The "old style" terminal width of IBM PC's with >> 80 columns used in the Java line length migrated in the meantime to another >> "common" line length: Most terminal applications have a default length of >> e.g. 132 already - so I would make this number (around 130) the "most >> common" standard! Interestingly, the avg line length of Lucene code is >> already smaller! >> >> Uwe >> >> ----- >> Uwe Schindler >> H.-H.-Meier-Allee 63, D-28213 Bremen >> http://www.thetaphi.de >> eMail: [email protected] >> >> > -----Original Message----- >> > From: Toke Eskildsen [mailto:[email protected]] >> > Sent: Monday, February 25, 2013 11:39 AM >> > To: [email protected] >> > Subject: Line length in Lucene/Solr code >> > >> > According to https://wiki.apache.org/solr/HowToContribute, Sun's code >> style >> > conventions should be used when writing contributions for Lucene and >> Solr. >> > Said conventions state that lines in code should be 80 characters or >> less, >> > "since they're not handled well by many terminals and tools": >> > http://www.oracle.com/technetwork/java/javase/documentation/codecon >> > ventions-136091.html#313 >> > >> > A quick random inspection of the Lucene/Solr code base tells me that >> this >> > recommendation is not followed: Out of 20 source files, only a single >> one >> > adhered to the 80 characters/line limit and that was StorageField, >> which is an >> > interface. >> > >> > I am all for a larger limit as I find that it makes Java code a lot >> more readable. >> > With current tools, Java code needs to be formatted using line breaks >> and >> > indents (as opposed to fully dynamic tool-specific re-flow of the >> code). That >> > formatting is dependent on a specific maximum line width to be >> consistent. >> > >> > >> > With that in mind, I suggest that the code style recommendation is >> expanded >> > with the notion that a maximum of x characters/line should be used, >> where x >> > is something more than 80. Judging by a quick search, 120 chars seems >> to be >> > a common choice. >> > >> > Regards, >> > Toke Eskildsen >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [email protected] For >> additional >> > commands, e-mail: [email protected] >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> >
