[
https://issues.apache.org/jira/browse/SOLR-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13590382#comment-13590382
]
Dan Rosher commented on SOLR-4465:
----------------------------------
Looking at the patch I think that "default" needs to be in the solrconfig
otherwise it would result in a npe. Perhaps replace "default" with new
DefaultCollectorFactory(...) ? Also if the user requests a collector that
dosen't exist, this results in a npe too, Would it be better to throw an
exception in this case? The other option is to fall back to a default but this
would give unexpected results.
Additionally since the collector is free to alter results between requests, I
think it should be used to create the QueryResultKey object for caching
docSets, otherwise you going to get unexpected results. Perhaps
CollectorFactory should be an interface with signatures for
getCollector,getDocSetCollector and hashCode and equals. QueryResultKey can
then delegate to CollectorFactory.hashCode. Then have a default implementation
implementing the current hashCode for QueryResultKey. This would ensure
CollectorFactory implementors have thought about hashCode and are free to
simply extend the default CollectorFactory if they wish.
> Configurable Collectors
> -----------------------
>
> Key: SOLR-4465
> URL: https://issues.apache.org/jira/browse/SOLR-4465
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 4.1
> Reporter: Joel Bernstein
> Fix For: 4.2, 5.0
>
> Attachments: SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch,
> SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch, SOLR-4465.patch,
> SOLR-4465.patch, SOLR-4465.patch
>
>
> This issue is to add configurable custom collectors to Solr. This expands the
> design and work done in issue SOLR-1680 to include:
> 1) CollectorFactory configuration in solconfig.xml
> 2) Http parameters to allow clients to dynamically select a CollectorFactory
> and construct a custom Collector.
> 3) Make aspects of QueryComponent pluggable so that the output from
> distributed search can conform with custom collectors at the shard level.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
