[ 
https://issues.apache.org/jira/browse/SOLR-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609219#comment-13609219
 ] 

Hoss Man commented on SOLR-4622:
--------------------------------

Proposal...

1) change the example solr.xml on 4x and trunk to use the current hardcoded 
defaults as defaults for ht sys properties...

{noformat}
-  <cores adminPath="/admin/cores" defaultCoreName="collection1" 
host="${host:}" hostPort="${jetty.port:}" hostContext="${hostContext:}" 
zkClientTimeout="${zkClientTimeout:15000}">
+  <cores adminPath="/admin/cores" defaultCoreName="collection1" 
host="${host:}" hostPort="${jetty.port:8983}" hostContext="${hostContext:solr}" 
zkClientTimeout="${zkClientTimeout:15000}">
{noformat}

2) change the 4x code that uses DEFAULT_HOST_CONTEXT and DEFAULT_HOST_PORT to 
log a warning that they are deprecated if they are used, along with what their 
values are and how/where to explicitly set them

3) change the trunk code that uses DEFAULT_HOST_CONTEXT and DEFAULT_HOST_PORT 
to fail fast if they aren't specified in solr.xml.
                
> deprecate usage of DEFAULT_HOST_CONTEXT and DEFAULT_HOST_PORT
> -------------------------------------------------------------
>
>                 Key: SOLR-4622
>                 URL: https://issues.apache.org/jira/browse/SOLR-4622
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>
> Frequently, people who try to use solr cloud in a differnet servlet container 
> (or in a jetty other then the preconfigured one supplied) they can be easily 
> confused as to why/how/where solr is trying to hostContext=solr and 
> hostPort=8983.
> these can be explicitly overridden in solr.xml, and the defaults are setup to 
> read from system properties, but we should eliminate the hardcoded defaults 
> from the java code (where most users can't even grep for them) and instead 
> specify defaults for the sys properties in the example configs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to