[ 
https://issues.apache.org/jira/browse/SOLR-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627316#comment-13627316
 ] 

Hoss Man commented on SOLR-4622:
--------------------------------

NOTE: reviewing a recent question on solr-user makes me realize we should deal 
with "zkHost" in a similar fashion.

there is already support to read it from solr.xml and if not set then check a 
system property with the same name.  similar to the hostContext and hostPort 
changes already made above, using the zkHost system property directly should 
cause a warning in 4x encouraging people to add {{zkHost="$\{zkHost\}"}} to 
their solr.xml if they want ot continue to use a system property, and should be 
removed from trunk so that it falls back on the normal config property 
substitution instead of an explicit System.getProperty() call.
                
> deprecate usage of DEFAULT_HOST_CONTEXT and DEFAULT_HOST_PORT
> -------------------------------------------------------------
>
>                 Key: SOLR-4622
>                 URL: https://issues.apache.org/jira/browse/SOLR-4622
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>             Fix For: 4.3, 5.0
>
>         Attachments: SOLR-4622.patch
>
>
> Frequently, people who try to use solr cloud in a differnet servlet container 
> (or in a jetty other then the preconfigured one supplied) they can be easily 
> confused as to why/how/where solr is trying to hostContext=solr and 
> hostPort=8983.
> these can be explicitly overridden in solr.xml, and the defaults are setup to 
> read from system properties, but we should eliminate the hardcoded defaults 
> from the java code (where most users can't even grep for them) and instead 
> specify defaults for the sys properties in the example configs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to