[
https://issues.apache.org/jira/browse/SOLR-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634432#comment-13634432
]
Mark Miller commented on SOLR-4725:
-----------------------------------
I focused so much on dataDir, I didn't even really consider name (also hadn't
just been in the code as I have been now).
I agree that support for name should remain in the properties - and that as it
does at the moment, if it's absent, we just default it to the dir name. Perhaps
we should populate the properties file with it as well, and not count on the
dir name over time.
> Should we stop supporting "name" and "dataDir" in the autodiscover mode?
> ------------------------------------------------------------------------
>
> Key: SOLR-4725
> URL: https://issues.apache.org/jira/browse/SOLR-4725
> Project: Solr
> Issue Type: New Feature
> Affects Versions: 4.3, 5.0
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Blocker
> Attachments: SOLR-4725.patch
>
>
> Making this a blocker so we resolve it. Should be quick to code if we have
> consensus, maybe nothing at all to do here.
> I'm not too happy with the fact that the new core discovery process has two
> real gotcha's. The individual core.properties file can define 'name' and
> 'dataDir'. It seems too easy to either use the same name for two different
> cores or use the same dataDir, just copy the core.properties file around and
> fail to edit one them. In large installations this could be a bear to track
> down.
> Straw-man proposal is the we remove support for them both in discovery mode.
> The name defaults to the directory in which core.properties is found and the
> data dir is immediately below there.
> Currently, there are checks to fail to load either core if either 'name' or
> 'dataDir' is defined in more than one core. I think the error reporting is
> weak, you probably have to look in the log file and there should be a way to
> get this in the admin UI at least.
> Maybe the right thing to do is just leave it as-is and emphasize that
> specifying the dataDir and name is expert level and you have to get it right,
> but I wanted to get wider exposure to the problem before we push 4.3 out.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
