[ 
https://issues.apache.org/jira/browse/SOLR-4725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634500#comment-13634500
 ] 

Shawn Heisey commented on SOLR-4725:
------------------------------------

If you have cores that don't have explicit name attributes, I think that a 
message should be logged saying that certain API actions like SWAP and RENAME 
will not be available.  I don't know if it should be WARN or INFO.  It would be 
OK if the message is only logged when the core is first loaded, not on RELOAD.  
Similarly, those actions should not be allowed when the name attribute is 
missing from cores named on the API call in the 'core' and 'other' parameters.  
If they are attempted an ERROR should be logged and returned in the http 
response.

Or we could avoid that whole can of worms by making the name attribute 
mandatory, pretty much the exact opposite of this issue. :)

The dataDir parameter is currently optional.  There was a problem with RENAME 
on the mailing list today where a user had all their cores sharing the same 
instanceDir, but dataDir was missing on all of them.  I will go ahead and file 
an issue for that.  Is sharing an instanceDir possible with automatic core 
discovery?

                
> Should we stop supporting "name" and "dataDir" in the autodiscover mode?
> ------------------------------------------------------------------------
>
>                 Key: SOLR-4725
>                 URL: https://issues.apache.org/jira/browse/SOLR-4725
>             Project: Solr
>          Issue Type: New Feature
>    Affects Versions: 4.3, 5.0
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Blocker
>         Attachments: SOLR-4725.patch
>
>
> Making this a blocker so we resolve it. Should be quick to code if we have 
> consensus, maybe nothing at all to do here.
> I'm not too happy with the fact that the new core discovery process has two 
> real gotcha's. The individual core.properties file can define 'name' and 
> 'dataDir'. It seems too easy to either use the same name for two different 
> cores or use the same dataDir, just copy the core.properties file around and 
> fail to edit one them. In large installations this could be a bear to track 
> down.
> Straw-man proposal is the we remove support for them both in discovery mode. 
> The name defaults to the directory in which core.properties is found and the 
> data dir is immediately below there.
> Currently, there are checks to fail to load either core if either 'name' or 
> 'dataDir' is defined in more than one core. I think the error reporting is 
> weak, you probably have to look in the log file and there should be a way to 
> get this in the admin UI at least.
> Maybe the right thing to do is just leave it as-is and emphasize that 
> specifying the dataDir and name is expert level and you have to get it right, 
> but I wanted to get wider exposure to the problem before we push 4.3 out.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to